[build-script] Cleanup arg-parsing tests #14488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… understand parser. Moved the swift-sdks migration code to a new migration module and added testing for both the presets and migration modules. Also converted build-script to use the new presets parser.
…nown feature) and also changed the parser to skip all non-preset sections. Tests are included for these two behaviors.
…ndard subprocess library. Also implemented a small wrapper module around Xcrun using the new shell module.
…e unexpected failures if they still perform work.
…dded missing **kwargs to the _fake_popen method on the CommandExecutor.
…e as well as some unittests.
…migration modules.
|
@swift-ci please test |
|
Build failed |
|
Closing stale PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR mainly cleans up some of the argument parsing tests. It removes some duplicate code and uses the new presets module from #14422 and the shell module from #14430.
This furthers the efforts for completing SR-237
rdar://25281853