[Name lookup] Fix an issue with lazy named member lookup. #14498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue with lazy named member lookup where a sequence of lookups into a class based on full names (e.g., constraint(equalTo:constant:)) could prevent us from adding candidates with the same based name but different argument labels. Fixes SR-6834 / rdar://problem/36851018 (cherry picked from commit 0547845)
|
@swift-ci please test |
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Lazy name member lookup could miss some members declared in a Swift extension of an Objective-C class, incorrectly rejecting well-formed code.
Scope of Issue: We've only seen one instance of this in the wild, but name-lookup problems like this can manifest commonly.
Origination: Lazy name member lookup introduced this issue.
Risk: The fix here is very targeted and mirrors a fix we did back in December in a related part of the code-base, so the risk seems low.
Fixes: SR-6834 / rdar://problem/36851018
Reviewed By: @jrose-apple , @graydon