Skip to content

[WIP] Re-apply "SwiftSyntax: Teach SwiftSyntax to use SourceKitd to serialize syntax trees. (#14424)" #14506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 11, 2018
Merged

[WIP] Re-apply "SwiftSyntax: Teach SwiftSyntax to use SourceKitd to serialize syntax trees. (#14424)" #14506

merged 7 commits into from
Feb 11, 2018

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Feb 9, 2018

After removing white space changes and attempting to configure dependencies
correctly.

@nkcsgexi
Re-apply "SwiftSyntax: Teach SwiftSyntax to use SourceKitd to seriali…
3df742a 
…ze syntax trees. (#14424)"

After removing white space changes and attempting to configure dependencies
correctly.
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 9, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 9, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 9, 2018

@swift-ci please test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 9, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 9, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 9, 2018

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Feb 9, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 9, 2018

Build failed
Swift Test Linux Platform
Git Sha - 3df742a

@swift-ci
Copy link
Contributor

swift-ci commented Feb 9, 2018

Build failed
Swift Test OS X Platform
Git Sha - 3df742a

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 65a2b03

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 65a2b03

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 77d1cdb

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 77d1cdb

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test source compatibility

2 similar comments
@nkcsgexi
Copy link
Contributor Author

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test source compatibility

@nkcsgexi
Copy link
Contributor Author

We ran source compatibility suite three times in a row and they all passed. The dependency seems to be correctly configured now. I'll go ahead merging this and keep an eye on the bots.

@nkcsgexi nkcsgexi merged commit 2e03eac into swiftlang:master Feb 11, 2018
@nkcsgexi nkcsgexi deleted the re-apply-swift-lang branch February 11, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkcsgexi @swift-ci