Skip to content

runtime: fix build of the runtime tests for Windows #14564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

compnerd
Copy link
Member

Ensure that the local definition of the stdlib functions are marked for
export. We would previously mark the runtime functions as dllimport on
Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

@swift-ci please test and merge

Ensure that the local definition of the stdlib functions are marked for
export.  We would previously mark the runtime functions as dllimport on
Windows.
@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - fdba0da785279adf9aa093bd4f964ec92e61702e

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - fdba0da785279adf9aa093bd4f964ec92e61702e

@compnerd compnerd merged commit bb4fe4e into swiftlang:master Feb 14, 2018
@compnerd compnerd deleted the export branch February 14, 2018 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants