When generating debug info for AllocStackInst, make sure to describe #14573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
|
@swift-ci test platform linux |
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
…the alloca. This way an llvm.dbg.declare instrinsic is used, which is valid for the entire lifetime of the alloca. rdar://problem/36663932
adrian-prantl
force-pushed
the
36663932
branch
from
2d07ce8 to
ee707ab
Compare
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
Whan an alloca is dynamic, all FastISel can do is describe the register in which the address of of the dynamic alloca is kept, and if the value isn't used it will get kicked out by regalloc. rdar://problem/36663932
adrian-prantl
force-pushed
the
36663932
branch
from
ee707ab to
3c96333
Compare
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
|
Now it's failing with an unrelated error that is also failing on all other pull requests. @swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the alloca.
This way an llvm.dbg.declare instrinsic is used, which is valid for
the entire lifetime of the alloca.
rdar://problem/36663932