Fix an issue with the constraint favoring code in the constraint opti… #14584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
…mizer. The code was favoring overloads where *either* argument matched its parameter type and where both parameter types were the same. This is really overly broad and can result in bugs like the one here, where we only attempt the (Int, Int) -> Bool overload of '!=' despite the fact that it means forcing an optional. We should select the <T>(T?, T?) -> Bool overload instead, and inject the non-optional operand into an optional. Making this require *both* arguments to match mostly disables this optimization, though, since for somethin like "a"+"b"+"c" the second add has a type variable and string literal as arugments. So instead, we'll just disable this in cases where one argument is the optional of the other, to ensure we never try forcing one side. This also means we'll disable the optimization in cases where we would inject one operand into an optional, but that's likely find as we don't have long chains of expressions where that happens. Fixes rdar://problem/37073401.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mizer.
The code was favoring overloads where either argument matched its
parameter type and where both parameter types were the same. This
is really overly broad and can result in bugs like the one here, where
we only attempt the
overload of '!=' despite the fact that it means forcing an
optional. We should select the
overload instead, and inject the non-optional operand into an optional.
Fixes rdar://problem/37073401.