[wip] Bool toggle implementation #14586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
xwu
added
the
swift evolution pending discussion
xwu
reviewed
Feb 13, 2018
airspeedswift
requested changes
Feb 13, 2018
stdlib/public/core/Bool.swift
Outdated
| /// | ||
| /// bools[0].toggle() | ||
| /// // bools now contains [false, false] | ||
| mutating func toggle() { |
stdlib/public/core/Bool.swift
Outdated
| @@ -294,3 +294,19 @@ extension Bool { | |||
| return lhs ? true : try rhs() | |||
| } | |||
| } | |||
|
|
|||
| extension Bool { | |||
| @_inlineable // FIXME(sil-serialize-all) | |||
There was a problem hiding this comment.
I think you can drop the FIXME(sil-serialize-all) for this one. It's truly legitimately inlineable.
|
@chriseidhof We have in the docs directory information about the CI and testing. For the CI commands: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md For the testing: https://github.com/apple/swift/blob/master/docs/Testing.md If you have any comments/improvements, they are welcome as always = ). |
|
@swift-ci please test |
airspeedswift
approved these changes
Mar 16, 2018
|
why no |
|
That method already exists and is spelled |
AnthonyLatsis
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request accompanies SE-0199: Adding
toggletoBoolI don't know how to run the test suite and what the standards are for documentation. I'm happy to improve on the PR if someone with more knowledge can point things out.