Skip to content

[5.0][CSBindings] Form bindings correctly when they come from 'OptionalObj… #14621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Feb 14, 2018

…ect' constraint

Fixes a bug in getPotentialBindings when the source of the bindings
is 'OptionalObject' constraint and type variable is on the left-hand
side of that constraint, that makes such type variable always have an
optional type since right-hand side of 'OptionalObject' is its 'object'
type.

Resolves: rdar://problem/37508855
(cherry picked from commit 5208049)

…ect' constraint

Fixes a bug in `getPotentialBindings` when the source of the bindings
is 'OptionalObject' constraint and type variable is on the left-hand
side of that constraint, that makes such type variable always have an
optional type since right-hand side of 'OptionalObject' is its 'object'
type.

Resolves: rdar://problem/37508855
(cherry picked from commit 5208049)
@xedin
Copy link
Contributor Author

xedin commented Feb 14, 2018

@swift-ci please smoke test and merge

@xedin xedin changed the title [CSBindings] Form bindings correctly when they come from 'OptionalObj… [5.0][CSBindings] Form bindings correctly when they come from 'OptionalObj… Feb 14, 2018
@swift-ci swift-ci merged commit 28aff90 into swiftlang:swift-5.0-branch Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants