[Benchmarks] Update benchmarks to Swift 4 #14623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke benchmark |
airspeedswift
requested review from
Rostepher
and removed request for
Rostepher
|
sorry @Rostepher I mis-clicked you there... |
Build comment file:Optimized (O)Regression (10)
Improvement (21)
No Changes (331)
Unoptimized (Onone)Regression (16)
Improvement (10)
No Changes (336)
Hardware Overview |
|
@swift-ci please smoke test |
airspeedswift
changed the title
moiseev
reviewed
Feb 14, 2018
| data.withUnsafeMutableBytes { (ptr: UnsafeMutablePointer<UInt8>) -> () in | ||
| for i in 0..<data.count { | ||
| for i in 0..<n { |
There was a problem hiding this comment.
nah, suppressing an exclusive access warning
| @@ -144,7 +144,7 @@ let charToString = { (c: Character) -> String in String(c) } | |||
| let charToInt = stringToInt • charToString | |||
|
|
|||
| func sum<S: Sequence>(_ nums: S)->S.Iterator.Element where S.Iterator.Element: FixedWidthInteger { | |||
| return nums.reduce(0) { $0.0 + $0.1 } | |||
| return nums.reduce(0, +) | |||
There was a problem hiding this comment.
That'll start failing eventually.. I think. When the SE-110 is reconsidered again.
There was a problem hiding this comment.
I dislike that change so this is a pro not a con AFAIAC :), but the reason I changed it is cos it's now $0 and $1 so I think it's SE-110-compatible.
| @@ -50,7 +42,7 @@ func match(regexp: String, text: String) -> Bool { | |||
| } | |||
|
|
|||
| /* matchhere: search for regexp at beginning of text */ | |||
| func matchHere(_ regexp: String, _ text: String) -> Bool { | |||
| func matchHere(_ regexp: Substring, _ text: Substring) -> Bool { | |||
There was a problem hiding this comment.
Funny.. One would think that this would speed things up a little.
StringMatch | 7203 | 8176 | +13.5% | 0.88x
|
I don't think we need to rush it out, so let's give a full benchmark suite a try to validate that regressions we see in smoke run are not that bad, or otherwise. @swift-ci Please benchmark |
moiseev
approved these changes
Feb 14, 2018
|
@swift-ci please benchmark |
Build comment file:Optimized (O)Regression (12)
Improvement (16)
No Changes (334)
Unoptimized (Onone)Regression (12)
Improvement (8)
No Changes (342)
Hardware Overview |
|
@moiseev looks like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update benchmarks to Swift 4. Just seeing if doing this makes any of them change, first, then we'll see if we want to make this change at this particular time.
Also I'm immensely suspicious of all that
truncatingBitPattern:Edit: Looks like all OK except maybe some regressions in debug. We should probably do this.