[5.0] [GSB] Avoid unresolved dependent member types in generic signatures. #14626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GenericSignatureBuilder is allowing unresolved dependent member types to creep into generic signatures, which eventually blows up in name mangling. Prefer to pick dependent member types that are fully-resolved when choosing anchors. This is a spot fix; a better approach would eliminate the notion of unresolved dependent member types entirely from PotentialArchetype. That's tracked by rdar://problem/35839277. Fixes rdar://problem/36549499. (cherry picked from commit 8b04dd3)
|
@swift-ci please smoke test and merge |
DougGregor
deleted the
gsb-avoid-unresolved-dependent-member-types-5.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GenericSignatureBuilder is allowing unresolved dependent member
types to creep into generic signatures, which eventually blows up in
name mangling. Prefer to pick dependent member types that are
fully-resolved when choosing anchors.
This is a spot fix; a better approach would eliminate the notion of
unresolved dependent member types entirely from
PotentialArchetype. That's tracked by rdar://problem/35839277.
Fixes rdar://problem/36549499.