[4.1] [IDE] Teach type checker about conditional conformance extensions. #14634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No point in getting rid of the sugar so early.
Before conditional conformances, the archetypes in conformance extensions (i.e. extension Foo: SomeProtocol) were equivalent to those in the type decl, with the same protocol bounds and so on. The code for printing "synthesized" members relied on this fact. This commit teaches that code to deal with archetypes in the conditional conformance extension when required. Fixes rdar://problem/36553066 and SR-6930.
|
@swift-ci please test |
huonw
force-pushed
the
doc-conditional-conformances-4.1
branch
from
3948e63 to
f883c48
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Oh, whoops, didn't mean to nominate this one just yet. Don't merge please! |
|
@swift-ci please nominate |
akyrtzi
reviewed
Feb 16, 2018
|
I thought I did add them at the end of the file? Maybe I added them to the wrong file? |
|
Apologies, I misunderstood, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Explanation: The IDE type checker previously didn't understand that some extensions from which it copies items for documentation purposes (e.g.
extension Proto1 { ... }) might only be conditionally enabled (i.e. a conditional conformance likeextension Foo: Proto1 where T: Proto2and that the archetypes needed to understand the types of the new items might be different to the archetypes of the nominal type decl (i.e. the archetype forThas to conform toProto2for things to make sense). This resulted in somesubsts failing, and so canonical types not being remapped to the correct user-facing type for things like inclusion in documentation (meaning it can include things likevar last: τ_0_0.Element? { get }).• Scope of Issue: Only major code changes are in the IDE support code/SourceKit, and those were mostly mechanical.
• Origination: Missed place that needed updating for conditional conformances.
• Risk: Low: the changes are somewhat large (although only ~550 of the 1100 listed added/deleted lines are just changes to generated expected output for a test), but mostly mechanical change, defensively programmed.
• Reviewed By: @DougGregor
• Testing: Compiler regression tests, manual verification of toolchain in Xcode
• Radar / SR: rdar://problem/36553066