LoadableByAddress: Add better tuples support #14637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test and merge |
jrose-apple
reviewed
Feb 14, 2018
lib/IRGen/LoadableByAddress.cpp
Outdated
| auto *instToInsert = dyn_cast<UncheckedEnumDataInst>(userIns); | ||
| if (std::find(pass.uncheckedEnumDataInstsToMod.begin(), | ||
| pass.uncheckedEnumDataInstsToMod.end(), | ||
| instToInsert) == pass.uncheckedEnumDataInstsToMod.end()) { |
There was a problem hiding this comment.
Hint for the future: llvm::is_contained
shajrawi
force-pushed
the
tuples
branch
2 times, most recently
from
fcea46a to
2dc5ce1
Compare
|
@swift-ci Please test and merge |
shajrawi
force-pushed
the
tuples
branch
2 times, most recently
from
ca1dd61 to
c7def78
Compare
|
@swift-ci Please test and merge |
1 similar comment
|
@swift-ci Please test and merge |
|
@swift-ci Please test linux |
1 similar comment
|
@swift-ci Please test linux |
|
Build failed |
|
@swift-ci Please test linux |
|
Build failed |
When working with tuples, if the tuple does not contain a large loadable type but does contain a function signature, we currently do nothing. We should convert the function signature inside the tuple type instead.
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/37533053
When working with tuples, if the tuple does not contain a large loadable type but does contain a function signature, we currently do nothing.
We should convert the function signature inside the tuple type instead.