Skip to content

Revert string comparison #14657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Revert string comparison #14657

merged 1 commit into from
Feb 15, 2018

Conversation

lancep
Copy link
Contributor

@lancep lancep commented Feb 15, 2018

Revert to see if this fixes the failing Linux bots

@atrick
Copy link
Contributor

atrick commented Feb 15, 2018

@lancep An OS X test also began failing around the same time. (My PR testing hits this 100% of the time):

[ FAIL ] NSStringAPIs/Substring.replacingCharacters(in:with:)

To debug, run:
$ /Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/buildbot_incremental/swift-macosx-x86_64/test-appletvsimulator-x86_64/stdlib/Output/NSStringAPI+Substring.swift.tmp/a.out4 --stdlib-unittest-in-process --stdlib-unittest-filter "replacingCharacters(in:with:)"

https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RD_test-simulator/671/

@lancep
Copy link
Contributor Author

lancep commented Feb 15, 2018

Please test with following pull request:
swiftlang/swift-corelibs-foundation#1435

@swift-ci please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants