-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[benchmarks] Add benchmarks based on different remove(where:) implementations #14662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
swift-ci
merged 1 commit into
swiftlang:master
from
airspeedswift:remove-where-benchmark
Feb 16, 2018
Merged
[benchmarks] Add benchmarks based on different remove(where:) implementations #14662
swift-ci
merged 1 commit into
swiftlang:master
from
airspeedswift:remove-where-benchmark
Feb 16, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please smoke benchmark |
@swift-ci please smoke test |
airspeedswift
commented
Feb 15, 2018
|
||
public let RemoveWhere = [ | ||
// tests repeated remove(at:) calls in generic code | ||
BenchmarkInfo(name: "AARemoveWhereQuadraticStrings", runFunction: run_RemoveWhereQuadraticStrings, tags: [.validation, .api], setUpFunction: buildWorkload), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I forgot to remove the "AA"s. Will do that after the benchmark results come back.
Build comment file:Optimized (O)Regression (8)
Improvement (9)
No Changes (345)
Added (10)
Unoptimized (Onone)Regression (11)
Improvement (9)
No Changes (342)
Added (10)
Hardware Overview
|
0ee3bec
to
1e820dc
Compare
Unrelated failure... rebasing and trying again. |
@swift-ci please smoke test and merge |
1 similar comment
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't to test
remove(where:)
but rather to test some different implementations of it that exercise different parts of the standard library, some of which weren't getting benchmarked. Benchmarks of nativeremove(where:)
will be added to this file in future.