Shims: adjust the ICU interface #14674
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default ICU build will change the underlying type of the UChar type, with C++ using the builtin `char16_t` rather than `unsigned short`. This adjusts the interface to account for that. I've verified across Apple's implementation that they always use the `unsigned short` as the type for `UChar`. Since we cannot guarantee that the ICU interfaces are built the same way on all targets, especially when using the underlying system's ICU. Adjust the stubs implementation declaration to match the ICU header's declaration.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default ICU build will change the underlying type of the UChar type,
with C++ using the builtin
char16_trather thanunsigned short.This adjusts the interface to account for that. I've verified across
Apple's implementation that they always use the
unsigned shortas thetype for
UChar. Since we cannot guarantee that the ICU interfaces arebuilt the same way on all targets, especially when using the underlying
system's ICU.
Adjust the stubs implementation declaration to match the ICU header's
declaration.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.