[5.0] [ClangImporter] If a submodule named 'Private' is missing, ask Clang #14679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
…wiftlang#14673) Previously the recommended pattern for having a "private" interface for a public framework that was easy to strip out was to define an explicit submodule named 'Private'. However, that makes it all too easy to have dependencies from the public parts of the module on the private parts, and other such problems. We're now recommending that the private module map instead define a parallel module named with "_Private" as a suffix. Clang already implemented this, but Swift didn't get the same treatment. This fix tries to avoid hardcoding too much; it notes that this kind of remapping is limited to the name 'Private' as the second component of a module hierarchy, but doesn't actually encode the mapping with the "_Private" suffix. rdar://problem/37553763 (cherry picked from commit af4d4e9)
jrose-apple
force-pushed
the
5.0-private-detective
branch
from
cdc78bd to
5ac30ac
Compare
|
@swift-ci Please smoke test |
|
This is going to need #14683 too, so I'll wait until that goes in and then cherry-pick it as well. |
(cherry picked from commit 0ef3492)
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #14673 to the 5.0 branch. Reviewed by @bcardosolopes.
rdar://problem/37553763