[ownership-verifier] Improve error message for owned values leaked du… #14706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to lack of "lifetime ending uses". The ownership verifier diagnoses leaks of owned objects in two different places/ways: 1. If the owned value does not have any "consuming" uses, we bail early without performing dataflow verification. 2. If the owned value has at least 1 "consuming" uses, we perform dataflow to determine the blocks where the leaked value escapes without being destroyed. In the latter case, we give a nice error message saying that a leak occured. In contrast in the former, we go down a "generic error" path that just says that a "lifetime ending use" is required. This commit changes that generic error message for owned parameters to say that the value was leaked, resulting in a clearer message. The other cases are still left along though. I also added a test file to specifically test leaks/leak error messages. I added a few tests to make sure this error message is correct and a few more tests just for fun.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e to lack of "lifetime ending uses".
The ownership verifier diagnoses leaks of owned objects in two different
places/ways:
performing dataflow verification.
determine the blocks where the leaked value escapes without being destroyed.
In the latter case, we give a nice error message saying that a leak occured. In
contrast in the former, we go down a "generic error" path that just says that a
"lifetime ending use" is required. This commit changes that generic error
message for owned parameters to say that the value was leaked, resulting in a
clearer message. The other cases are still left along though.
I also added a test file to specifically test leaks/leak error messages. I added
a few tests to make sure this error message is correct and a few more tests just
for fun.