-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Isolate Array bridging behavior for ABI stability #14717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke benchmark |
Build comment file:Optimized (O)Regression (2)
Improvement (7)
No Changes (369)
Unoptimized (Onone)Regression (6)
Improvement (10)
No Changes (362)
Hardware Overview
|
@swift-ci please test |
@swift-ci please test |
I think this is good to merge but I'd like some extra eyes on it first |
@swift-ci please smoke benchmark |
Build comment file:Optimized (O)Regression (5)
Improvement (3)
No Changes (370)
Unoptimized (Onone)Regression (13)
Improvement (10)
No Changes (355)
Hardware Overview
|
stdlib/public/core/Arrays.swift.gyb
Outdated
@@ -2381,6 +2381,11 @@ extension ${Self} { | |||
%end | |||
|
|||
#if _runtime(_ObjC) | |||
@_versioned internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment describing why this is here. Otherwise, someone will just delete it
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with that comment, lgtm.
Did you have an eager bridging PR? We could check in something that conditionally enables it based on build parameters. |
I do, but it'll need to be substantially changed if we were to do that. |
rdar://problem/35943342