Fix em dash and apostrophe presentation in the Swift man page. #14719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminal currently renders em dashes and apostrophes incorrectly: "please file a report to AppleXs bug reporter" "features X being fast is rare" Also reformats some whitespace to remove a double space after a sentence: "a great way for anyone to help improve Swift. The bug tracker"
|
@swift-ci Please smoke test |
|
@natecook1000 or @xwu sanity check appreciated, but I think this is fairly straightforward. It didn't break or add new warnings to |
natecook1000
approved these changes
Feb 20, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminal (
man swift) currently renders em dashes and apostrophes incorrectly (as the letter X rather than the proper symbol):This PR replaces those characters with their ASCII-safe representations. If there's a nice way to use the semantically-correct characters in the POD format, I'd be happy to use that way, too, but this fix is better than the current situation.
This PR makes a small change nearby in the same document: it reformats some whitespace to remove a double space after a sentence: