Skip to content

Remove 'public' from a few NSError-bridging-related symbols #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

jrose-apple
Copy link
Contributor

We're still using most of this, but not all of it has to be public.

rdar://problem/35230025

We're still using most of this, but not all of it has to be public.

rdar://problem/35230025
@jrose-apple jrose-apple requested a review from phausler February 20, 2018 03:48
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

Review ping

Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me, anyone using underscored symbols will get a failure but that is probably ok.

@jrose-apple jrose-apple merged commit f7bb041 into swiftlang:master Mar 20, 2018
@jrose-apple jrose-apple deleted the out-of-sight branch March 20, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants