[4.1][AST] Retrive EndLine after StartLineAndColumn for SingleRawComment #14735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm::SourceMgr caches the line and column of the last query. It usually scans from that position for subsequent queries. However, if the query is for a position ahead of the last query, it re-scan from the top of the whole buffer. This significally slows down the performance. This change effectively mitigate performance regression introduced in swiftlang#11264 without functional changes.
|
@swift-ci Please test |
rintaro
changed the title
rintaro
changed the title
akyrtzi
approved these changes
Feb 20, 2018
I don't think there's simple way to assert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #14733 to swift-4.1-branch
Explanation:
llvm::SourceMgrcaches the position and the line number of the last query. For subsequent queries, It usually scans from that position. However, if the query is for a position ahead of the last query, it re-scan from the top of the whole buffer. This significantly slows down the performance.This change reorder the queries to
llvm::SourceMgrso that they aligns the order of appearance in the source file. This change effectively mitigate performance regression introduced in #11264 without functional changes.Scope: SourceKit and ASTSerialization. Changes are localized in
SingleRawCommentclass, no interface change.Radar/SR: rdar://problem/37570893
Risk: Low. No API change. This change is just for utilizing cache functionality of
llvm::SourceMgrTesting: Passes all tests.
Reviewer: @akyrtzi @benlangmuir