-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[5.0][AST] Retrive EndLine after StartLineAndColumn for SingleRawComment #14737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xedin
merged 1 commit into
swiftlang:swift-5.0-branch
from
rintaro:5.0-ast-comment-endline
Feb 22, 2018
Merged
[5.0][AST] Retrive EndLine after StartLineAndColumn for SingleRawComment #14737
xedin
merged 1 commit into
swiftlang:swift-5.0-branch
from
rintaro:5.0-ast-comment-endline
Feb 22, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm::SourceMgr caches the line and column of the last query. It usually scans from that position for subsequent queries. However, if the query is for a position ahead of the last query, it re-scan from the top of the whole buffer. This significally slows down the performance. This change effectively mitigate performance regression introduced in swiftlang#11264 without functional changes.
@swift-ci Please smoke test |
Linux failure: https://ci.swift.org/job/swift-PR-Linux-smoke-test/4583/
|
@swift-ci Please smoke test Linux platform |
@swift-ci Please smoke test Linux platform |
Force merging since this hits known problem in foundation on Linux + 5.0 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #14733 to swift-5.0-branch.
rdar://problem/37570893