[Demangler] Add convenience functions to ask about types. #14748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use them in the reflection library (TypeRef). These were private to `TypeRef.cpp` but can be moved to the demangler as they can be of general use, and we can use them from lldb (which has homemade versions of the functions as well). Bonus point, it probably makes sense for these helpers to live in the demangler anyway. <rdar://problem/37710513>
|
@swift-ci please test |
|
Thanks for the review @eeckstein ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use them in the reflection library (TypeRef). These were
private to
TypeRef.cppbut can be moved to the demangler asthey can be of general use, and we can use them from lldb (which
has homemade versions of the functions as well). Bonus point,
it probably makes sense for these helpers to live in the demangler
anyway.
rdar://problem/37710513