Allow 'public' classes to have 'internal' required initializers #14775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
This seems reasonable to me. More generally, |
|
Ah, you can still write extensions of a non-open class, so I'm not sure I want to go there yet. And if the initializer is public then it can still be initialized dynamically across module boundaries. |
They're already not subclassable publicly, so it's okay for the initializer to not be available to cross-module clients, just like if it were non-'required'. This allows constructing a class instance chosen at runtime /within/ the module without having to expose the existence of the constructor to everybody. rdar://problem/22845087
jrose-apple
force-pushed
the
tired-wired-required
branch
from
6118e43 to
b599d66
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're already not subclassable publicly, so it's okay for the initializer to not be available to cross-module clients, just like if it were non-'required'. This allows constructing a class instance chosen at runtime within the module without having to expose the existence of the constructor to everybody.
rdar://problem/22845087