[Metadata/IRGen] NFC: Couple of field metadata related improvements #14776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
jckarter
requested changes
Feb 21, 2018
|
|
||
| int compareWithKey(const Metadata *other) const { | ||
| return Base == other; | ||
| return Type == other ? 0 : (Type < other ? -1 : 1); |
There was a problem hiding this comment.
Comparing unrelated pointers is UB in C/C++. Strictly, you need to do (uintptr_t)Type < (uintptr_t)Other there.
There was a problem hiding this comment.
Ah interesting, thanks!
xedin
force-pushed
the
rdar-26060144-improvements
branch
from
91e822e to
333f614
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
jckarter
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does following:
Resolves: rdar://problem/26060144