[4.1][stdlib] Remove the unnecessary compactMap overload #14779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moiseev
commented
Feb 21, 2018
moiseev
commented
- Explanation: Remove an unnecessary overlad that was introduced by mistake.
- Risk: Minimal, as compactMap were introduced only recently
- Reviewed By: Ben Cohen
- Testing: Automated test suite + compatibility test suite
- Directions for QA: N/A
- Radar: rdar://problem/37764446
This particular overload of compactMap was mechanically copied from the `flatMap` while implementing SE-0187, but as community members correctly noticed on the forum thread [here](https://forums.swift.org/t/why-is-there-a-collection-flatmap-that-takes-a-closure-returning-string/10141), there is no code that we should be backward compatible with, since `compactMap` has only been introduced recently. After applying this change, the following code is correctly ambiguous again: ```swift [].compactMap { _ in nil } // error: 'nil' requires a contextual type ``` as opposed to: ```swift [].flatMap { _ in nil } // r0 : [String] = [] ``` Fixes: https://bugs.swift.org/browse/SR-7052 (cherry picked from commit 9d70574)
|
@swift-ci Please test |
|
@swift-ci Please Test Source Compatibility |
|
@swift-ci Please nominate |
|
@swift-ci Please test |
|
@swift-ci Please Test Source Compatibility |
1 similar comment
|
@swift-ci Please Test Source Compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.