Skip to content

[master] ClangImporter: Update Swift for changes in clang (PCH + Modules issues) #14786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

jrose-apple
Copy link
Contributor

This sets the NeededByPCHOrCompilationUsesPCH language option when emitting a brigding PCH.

rdar://problem/35056912
rdar://problem/30384801

(cherry picked from commit 5d5f542)

This sets the NeededByPCHOrCompilationUsesPCH language option when
emitting a brigding PCH.

rdar://problem/35056912
rdar://problem/30384801

Initial patch by Adrian Prantl

(cherry picked from commit 5d5f542)
@jrose-apple
Copy link
Contributor Author

@xedin, this is a speculative fix for the failures on the master Linux bots. @bcardosolopes, in the future please commit to master first and then cherry-pick to release branches.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 5d28e61 into swiftlang:master Feb 22, 2018
@jrose-apple jrose-apple deleted the pch-woes branch February 22, 2018 18:05
@xedin
Copy link
Contributor

xedin commented Feb 22, 2018

Thank you!

@bcardosolopes
Copy link
Contributor

Thanks Jordan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants