Skip to content

Move the metadata-pattern header into the type context descriptor #14826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rjmccall
Copy link
Contributor

@rjmccall rjmccall commented Feb 25, 2018

This is yet another waypoint on the path towards the final generic-metadata design. The immediate goal is to make the pattern a private implementation detail and to give the runtime more visibility into the allocation and caching of generic types.

The next step is to allow class metadata to be allocated without already having the superclass metadata. This will require the addition of a superclass descriptor reference to class descriptors.

@rjmccall
Copy link
Contributor Author

@swift-ci Please test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7a467e90d5ed38d9dbcb25169450830b1c7446b2

@rjmccall rjmccall force-pushed the consolidate-patterns-into-descriptors branch from 7a467e9 to 7fbde87 Compare February 25, 2018 21:45
@rjmccall
Copy link
Contributor Author

@swift-ci Please test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7a467e90d5ed38d9dbcb25169450830b1c7446b2

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7a467e90d5ed38d9dbcb25169450830b1c7446b2

@rjmccall
Copy link
Contributor Author

Never make one last innocuous change without building before pushing out for testing, folks.

@rjmccall rjmccall force-pushed the consolidate-patterns-into-descriptors branch from 7fbde87 to d7c0418 Compare February 26, 2018 03:15
@rjmccall
Copy link
Contributor Author

@swift-ci Please test OS X.

1 similar comment
@rjmccall
Copy link
Contributor Author

@swift-ci Please test OS X.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d7c0418f5d3dea1de20acc90afadc7035a367d8f

@rjmccall rjmccall force-pushed the consolidate-patterns-into-descriptors branch from d7c0418 to 8e91427 Compare February 26, 2018 03:21
@rjmccall
Copy link
Contributor Author

@swift-ci Please test OS X.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d7c0418f5d3dea1de20acc90afadc7035a367d8f

@rjmccall rjmccall force-pushed the consolidate-patterns-into-descriptors branch from 8e91427 to 9ed4001 Compare February 26, 2018 03:39
@rjmccall
Copy link
Contributor Author

@swift-ci Please test OS X.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8e91427286f90ec3b392ac516d2500d322fc5e28

@rjmccall rjmccall force-pushed the consolidate-patterns-into-descriptors branch from 9ed4001 to c8920d0 Compare February 26, 2018 04:08
@rjmccall
Copy link
Contributor Author

@swift-ci Please test OS X.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9ed40016c475ee8a1e85c8d111f9e19471e644cb

@rjmccall rjmccall force-pushed the consolidate-patterns-into-descriptors branch from c8920d0 to ddfa308 Compare February 26, 2018 04:13
@rjmccall
Copy link
Contributor Author

@swift-ci Please test OS X.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c8920d0745c63e1475dc289ad6c0dd0a425f4fe6

@rjmccall rjmccall force-pushed the consolidate-patterns-into-descriptors branch from ddfa308 to 08516b7 Compare February 26, 2018 06:41
@rjmccall
Copy link
Contributor Author

@swift-ci Please test and merge.

1 similar comment
@rjmccall
Copy link
Contributor Author

@swift-ci Please test and merge.

@rjmccall rjmccall force-pushed the consolidate-patterns-into-descriptors branch from 08516b7 to 420681f Compare February 26, 2018 08:29
@rjmccall
Copy link
Contributor Author

@swift-ci Please test and merge.

1 similar comment
@rjmccall
Copy link
Contributor Author

@swift-ci Please test and merge.

This is yet another waypoint on the path towards the final
generic-metadata design.  The immediate goal is to make the
pattern a private implementation detail and to give the runtime
more visibility into the allocation and caching of generic types.
@rjmccall rjmccall force-pushed the consolidate-patterns-into-descriptors branch from 420681f to dd99536 Compare February 26, 2018 17:17
@rjmccall
Copy link
Contributor Author

@swift-ci Please smoke test and merge.

1 similar comment
@rjmccall
Copy link
Contributor Author

@swift-ci Please smoke test and merge.

@swift-ci swift-ci merged commit fa998b1 into swiftlang:master Feb 26, 2018
@rjmccall rjmccall deleted the consolidate-patterns-into-descriptors branch February 26, 2018 19:09
@rjmccall rjmccall changed the title [WIP] Move the metadata-pattern header into the type context descriptor Move the metadata-pattern header into the type context descriptor Feb 26, 2018
@rjmccall
Copy link
Contributor Author

Of course I forget to take [WIP] out of the PR name before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants