-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[arc] An apply of a callee_guaranteed thick function is a "guaranteed… #14832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[arc] An apply of a callee_guaranteed thick function is a "guaranteed… #14832
Conversation
… use" of the function. rdar://37820485 (cherry picked from commit 4941fba)
@swift-ci test |
Build failed |
The linux failure is due to git issue on the servers. Running again. |
@swift-ci test linux platform |
Build failed |
@swift-ci test linux platform |
Build failed |
This passed testing, but the smoke test label builder didn't trigger appropriately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation: When callee_guaranteed was enabled, the ARC optimizer was not taught that applying a callee_guaranteed thick function is a guaranteed use of the thick function. This PR fixes said issue. |
@swift-ci test linux platform |
… use" of the function.
rdar://37820485
(cherry picked from commit 4941fba)