IRGen: The type layout of a metatype is not the same as the NativeObj… #14891
Conversation
…ect.Type rdar://37924505
|
@swift-ci Please test |
|
Hmm, maybe I can tighten this up more by distinguishing between ExistentialMetatypeType and MetatypeType. |
|
@swift-ci Please smoke test |
|
Build failed |
|
Build failed |
lib/IRGen/GenMeta.cpp
Outdated
| } else { | ||
| // Thick metatypes look like pointers with spare bits. | ||
| return emitFromValueWitnessTable( | ||
| CanMetatypeType::get(IGF.IGM.Context.TheNativeObjectType)); |
There was a problem hiding this comment.
Should this just fall through, since the ObjC case below is the same?
There was a problem hiding this comment.
I find conditional fall-throughs rather confusing. They have the potential issue that you could modify the code in the future that we fall through to in a way that is only meant for latter case (not the case we fall-through from) without realizing, similar when you add a case to the switch. Is this a likely scenario here? Maybe not.
Anyways, I defer to you.
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
…ect.Type
rdar://37924505