Skip to content

[SourceKitd] Avoid printing parent type directly on extended type. rdar://37965902 #14892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2018
Merged

[SourceKitd] Avoid printing parent type directly on extended type. rdar://37965902 #14892

merged 1 commit into from
Mar 1, 2018

Conversation

nkcsgexi
Copy link
Contributor

When printing parent type directly, we may print generic arguments and sugared
dictionary type.

…ar:37965902

When printing parent type directly, we may print generic arguments and sugared
dictionary type.
@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

1 similar comment
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Mar 1, 2018

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Mar 1, 2018

@huonw does this change look safe to you for swift-4.1-branch?

@nkcsgexi nkcsgexi requested a review from huonw March 1, 2018 16:27
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems safe to me.

@nkcsgexi nkcsgexi merged commit 9f39c84 into swiftlang:master Mar 1, 2018
@nkcsgexi nkcsgexi deleted the avoid-using-parent-type branch March 1, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants