build: emulate /GR- when compiling for Windows #14917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /GR- emulation is needed to support building on Windows. std::function in Microsoft's C++ runtime requires the use of `typeid`. We do not want to emit RTTI data. `-frtti -fno-rtti-data` allows the use of the `typeid` and `dynamic_cast` behaviours but will not emit the RTTI data. With this change, it is possible to build the Windows runtime once again.
|
@swift-ci please test and merge |
|
@compnerd can you add a build system unittest that checks that we don't emit rtti? I would just copy what I did for the lto tests. |
|
@gottesmm mind pointing me to the commit so I can take a look at it and try to do something similar? |
|
@compnerd no problem! Here it the commit: ehttps://github.com/apple/swift/commit/95d926abb0e2e1cd9f5dab07802839e0d1ce5b41 And here is the file today: https://github.com/apple/swift/tree/master/validation-test/BuildSystem/LTO |
|
Also, if it is difficult to do such a thing (i.e. there isn't a tool that does this out of the box, don't worry about it). But if we can... etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /GR- emulation is needed to support building on Windows.
std::function in Microsoft's C++ runtime requires the use of
typeid.We do not want to emit RTTI data.
-frtti -fno-rtti-dataallows theuse of the
typeidanddynamic_castbehaviours but will not emit theRTTI data. With this change, it is possible to build the Windows
runtime once again.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.