Determine whether a given sanitizer is available based on the presenc… #14919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of the library. rdar://37192887
|
@swift-ci please test |
kubamracek
reviewed
Mar 1, 2018
lib/Option/SanitizerOptions.cpp
Outdated
| Diags.diagnose(SourceLoc(), diag::error_unsupported_option_argument, | ||
| A->getOption().getPrefixedName(), A->getValue(i)); | ||
| } else if (sanitizerRuntimeLibExists(toFileName(*kind), isShared) | ||
| && (*kind != SanitizerKind::Thread || Triple.isArch64Bit())) { |
There was a problem hiding this comment.
Can we keep the helper function "isTSanSupported"? Even if it's just a test for .isArch64bit. This condition is very hard to read.
There was a problem hiding this comment.
@kubamracek keeping the function does not make sense, as we now check existence of all sanitizers. I've tried to rewrite the condition to make it more readable.
There was a problem hiding this comment.
Can we then just be a bit more verbose here? Something like
bool sanitizerSupported = true;
if (*kind == Thread) {
if (!Triple.is64bit() sanitizerSupported = false; // TSan requires 64-bit architecture
}
...
|
Besides the comment, this LGTM. Thanks! |
|
Build failed |
|
@swift-ci please smoke test |
|
LGTM. Thanks! |
kubamracek
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e of the library.
rdar://37192887
Basically, if the library is there, the sanitizer is available. IF not, then it's not available.