Add benchmark for UTF-8 decoding #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I'd recommend adding multiple long runs of 2-byte and 3-byte characters into the test string. That's the typical case, whereas mixed-language case is not. |
|
What do you mean by 'pre-multiply'? |
|
The other benchmark do |
|
@gottesmm What's your recommendation? |
|
We only pre-multiply if a single iteration (N=1) doesn't provide a stable duration to multiply off of to reach a one second sample. If you're seeing a one second sample time, don't pre-multiply. |
|
@swift-ci Please test |
|
Ok this test case probably needs a pre-applied multiplier because the setup code otherwise would skew the results, will add one. |
lplarson
added a commit
that referenced
this pull request
Mar 2, 2016
Add benchmark for UTF-8 decoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Adds a performance test for UTF-8 decoding.
I didn't pre-multiply N, since the README suggest that, but the other benchmarks all seem to be premultiplying it. What's the preferred approach here?
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.