[BatchMode] Make driver report exits per-batch, not per-constituent. #14931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
(@jrose-apple I know this should have its own dedicated test; I'll try to write one tomorrow, a bit late for it tonight) |
|
Yes, test please! And how does this appear in Xcode's build log? (Maybe attach a screenshot of Xcode 9.3b3, if that handles it well enough?) |
jrose-apple
approved these changes
Mar 2, 2018
|
@jrose-apple It doesn't look fantastic in that, like with WMO, you no longer see the individual files, but it's not so bad; just looks like "multiple instances of WMO".
|
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was overzealous in the amount of work I made the driver do on a per-constituent basis when a task exits. The driver's model of the task should be per-constituent, but the Pid-based reporting and output-writing should happen per-batch.
(And doing anything in the signalling patch per-constituent is pointless; it only does one thing).
This is required to run batch mode correctly under xcodebuild, or in general anything reading parseable-output. And it's required to make sense of the output in any case.
(And with this change, substantial parts of the source compat suite build in batch mode)