[SR-832][Sema] Fix for function type args passed to @autoclosure params #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a function type to an @autoclosure param would always fail to type check because of the attempt to decompose the parallel structure of the two (both being functions). In this case, though, we don’t want to do any such thing, we want to allow the ExprRewriter to explicitly insert an AutoClosureExpr in coerceToType, as it would do with any other non-function arg type.
|
I'm just curious whether this will work with having a commit bit now: @swift-ci Please test |
|
@gregomni In my email Ted mentioned that only Apple contributors can trigger CI for now. |
|
@dduan Thanks! Yep, he told me the same, but since the swift-ci blog post says "with commit access", I thought I'd give it a shot anyway to make sure. |
|
@swift-ci Please test |
gregomni
added a commit
that referenced
this pull request
Mar 1, 2016
[SR-832][Sema] Fix for function type args passed to @autoclosure params
|
Awesome to see this fixed! |
|
Thanks @gregomni! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a function type to an @autoclosure param would always fail to type check because of the attempt to decompose the parallel structure of the two (both being functions). In this case, though, we don’t want to do any such thing, we want to allow the ExprRewriter to explicitly insert an AutoClosureExpr in coerceToType, as it would do with any other non-function arg type.