Removed redundant check #14952
Merged
Removed redundant check #14952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since init for Int with empty string returns nil there is no need for additional checking for empty string
gottesmm
reviewed
Mar 3, 2018
benchmark/utils/DriverUtils.swift
Outdated
| @@ -208,9 +208,6 @@ struct TestConfig { | |||
| } | |||
|
|
|||
| if let x = benchArgs.optionalArgsMap["--sleep"] { | |||
| if x.isEmpty { | |||
| return .fail("--sleep requires a non-empty integer value") | |||
| } | |||
| let v: Int? = Int(x) | |||
| if v == nil { | |||
There was a problem hiding this comment.
Good point! Couldn't you simplify this further by using a guard let? I.e.:
if let x = benchArgs.optionalArgsMap["--sleep"] {
guard let v = Int(x) else {
return .fail("...")
}
afterRunSleep = v
}
There was a problem hiding this comment.
Yes I can, thats even better now
|
LGTM |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because initialising Int with empty string returns nil there is no need for this additional check for empty string. This should simplify this code a bit.