Skip to content

+0 Guaranteed Arguments #14953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2018
Merged

+0 Guaranteed Arguments #14953

merged 4 commits into from
Mar 20, 2018

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Mar 3, 2018

This PR contains the final work to convert the compiler to +0. There are still some tests failing, but I would like to get start performing PR testing of the branch.

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci smoke benchmark

(just for testing purposes)

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci test source compatibility

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci smoke benchmark

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

Forgot to turn on +0 in the runtime... sorry! So now I need to restart everything = (.

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci test source compatibility

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci test source compatibility

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci smoke benchmark

3 similar comments
@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci smoke benchmark

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci smoke benchmark

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2018

@swift-ci smoke benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Mar 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - 1c07675a15456ac43e177010be492f8cf313149d

@swift-ci
Copy link
Contributor

swift-ci commented Mar 3, 2018

Build failed
Swift Test OS X Platform
Git Sha - 1c07675a15456ac43e177010be492f8cf313149d

@swift-ci
Copy link
Contributor

swift-ci commented Mar 3, 2018

Build comment file:

Build failed before running benchmark.


@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 4, 2018

Debugging the swiftpm crash now.

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 4, 2018

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 4, 2018

(the reason why it is interesting is that there is a last runtime fix that I need to look at around subclassing existentials getting wonky and I think the way this code is working, subclass existentials come up, but I need to look further at the SIL.

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 4, 2018

(i.e. I just reduced the swift test case a bit)

@gottesmm gottesmm force-pushed the plus-0-final branch 3 times, most recently from 2aaf8fe to 44b3ebf Compare March 5, 2018 18:34
@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 6, 2018

Alright... lets try this again.

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 6, 2018

@swift-ci test

2 similar comments
@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 6, 2018

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 6, 2018

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 6, 2018

@swift-ci smoke benchmark

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 09cd348

@gottesmm
Copy link
Contributor Author

Hmm... interesting. I guess I did not resolve the merge conflict perfectly. Lets see.

@gottesmm
Copy link
Contributor Author

I figured out the lldb problem in concert with @jimingham. We have changed stepping behavior slightly. I am fixing now.

@gottesmm
Copy link
Contributor Author

lldb update PR: apple/swift-lldb#427

@gottesmm
Copy link
Contributor Author

Going to fix the merge conflict and wait for the dust to settle a little from the day now that I hopefully can avoid merge conflicts.

@gottesmm
Copy link
Contributor Author

@swift-ci test

2 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 09cd348

@gottesmm
Copy link
Contributor Author

@swift-ci test linux platform

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci test linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 2072dce5f099e80f9d2b30c9606c941ecad9dcc6

lldb-dotest does not forward the arguments from DOTEST_EXTRA properly.
For now, just build the lldb-dotest target to ensure the cmake build has
the right dependencies built. Invoke dotest.py manually as before.
@gottesmm
Copy link
Contributor Author

apple/swift-lldb#427

@swift-ci test

3 similar comments
@gottesmm
Copy link
Contributor Author

apple/swift-lldb#427

@swift-ci test

@gottesmm
Copy link
Contributor Author

apple/swift-lldb#427

@swift-ci test

@gottesmm
Copy link
Contributor Author

apple/swift-lldb#427

@swift-ci test

@gottesmm
Copy link
Contributor Author

apple/swift-lldb#427

@swift-ci test linux platform

@gottesmm
Copy link
Contributor Author

And its done.

@gottesmm gottesmm merged commit 54b38d4 into swiftlang:master Mar 20, 2018
@gottesmm gottesmm deleted the plus-0-final branch March 20, 2018 05:59
@eeckstein
Copy link
Contributor

awesome! great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants