-
Notifications
You must be signed in to change notification settings - Fork 10.5k
+0 Guaranteed Arguments #14953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+0 Guaranteed Arguments #14953
Conversation
@swift-ci test |
@swift-ci smoke benchmark (just for testing purposes) |
@swift-ci test source compatibility |
@swift-ci smoke benchmark |
Forgot to turn on +0 in the runtime... sorry! So now I need to restart everything = (. |
@swift-ci test |
@swift-ci test source compatibility |
@swift-ci test |
@swift-ci test source compatibility |
@swift-ci smoke benchmark |
Build failed |
Build failed |
Build comment file:Build failed before running benchmark. |
Debugging the swiftpm crash now. |
Interesting. It seems to be due to this line in swiftpm: |
(the reason why it is interesting is that there is a last runtime fix that I need to look at around subclassing existentials getting wonky and I think the way this code is working, subclass existentials come up, but I need to look further at the SIL. |
(i.e. I just reduced the swift test case a bit) |
2aaf8fe
to
44b3ebf
Compare
Alright... lets try this again. |
@swift-ci test |
@swift-ci smoke benchmark |
Build failed |
Hmm... interesting. I guess I did not resolve the merge conflict perfectly. Lets see. |
I figured out the lldb problem in concert with @jimingham. We have changed stepping behavior slightly. I am fixing now. |
lldb update PR: apple/swift-lldb#427 |
Going to fix the merge conflict and wait for the dust to settle a little from the day now that I hopefully can avoid merge conflicts. |
@swift-ci test |
Build failed |
rdar://34222540
@swift-ci test linux platform |
1 similar comment
@swift-ci test linux platform |
Build failed |
lldb-dotest does not forward the arguments from DOTEST_EXTRA properly. For now, just build the lldb-dotest target to ensure the cmake build has the right dependencies built. Invoke dotest.py manually as before.
3 similar comments
@swift-ci test linux platform |
And its done. |
awesome! great work! |
This PR contains the final work to convert the compiler to +0. There are still some tests failing, but I would like to get start performing PR testing of the branch.