Skip to content

[SR-1046] Pass lit path argument to xctest explicitly #14955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

nafu
Copy link
Contributor

@nafu nafu commented Mar 3, 2018

swift-corelibs-xctest uses the LLVM lit test runner to compile test cases and run them. The Swift build script, utils/build-script, does the same. The Swift build script already contains logic to find a lit executable. XCTest should use the same lit executable.

Resolves SR-1046.

@rintaro
Copy link
Member

rintaro commented Mar 3, 2018

cc: @briancroom @modocache

Copy link
Contributor

@modocache modocache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you, @nafu!

@modocache
Copy link
Contributor

@swift-ci please test and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants