[refactoring] Avoid producing empty string/comment categorized edit ranges when renaming init. Also disallow renaming inits with no arguments. #14980
+148
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nathawes
force-pushed
the
rdar37905156-rename-init-gives-empty-categorised-edit-ranges
branch
from
b9c507d to
22aa81e
Compare
nathawes
changed the title
…ming init. Also disallow renaming inits with no arguments.
nathawes
force-pushed
the
rdar37905156-rename-init-gives-empty-categorised-edit-ranges
branch
from
22aa81e to
91ec998
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please smoke test osx |
nathawes
deleted the
rdar37905156-rename-init-gives-empty-categorised-edit-ranges
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When renaming an initializer we don't try to pick up argument labels and also don't record the base name location, since you can't actually rename it. This means there are no ranges to rename, but we still return a categorized edit of type string/comment with no location information. This patch changes the category returned to unmatched, rather than string/comment, to indicate they shouldn't be handled.
Also stop showing rename as available on initializers that take no arguments, since nothing can be renamed.
Resolves rdar://problem/37905156.