Apply generic metadata patterns to all types and change their layout. #14998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout changes to become relative-address based. For this to be truly immutable (at least on Darwin), things like the RO data patterns must be moved out of the pattern header. Additionally, compress the pattern header so that we do not include metadata about patterns that are not needed for the type. Value metadata patterns just include the metadata kind and VWT. The design here is meant to accomodate non-default instantiation patterns should that become an interesting thing to support in the future, e.g. for v-table specialization.
|
@swift-ci Please test and merge. |
|
Apparently that is a pervasive failure unrelated to my patch. |
|
@swift-ci Please smoke test OS X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout changes to become relative-address based. For this to be truly immutable (at least on Darwin), things like the RO data patterns must be moved out of the pattern header. Additionally, compress the pattern header so that we do not include metadata about patterns that are not needed for the type.
Value metadata patterns just include the metadata kind and VWT.
The design here is meant to accomodate non-default instantiation patterns should that become an interesting thing to support in the future, e.g. for v-table specialization.