[GSB] Always ensure that we wire up typealiases in protocol extensions. #15002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During "expansion" of the requirements of a protocol, we check all of the inherited associated types against definitions within the protocol. Also look for concrete types within extensions of that protocol, so we can identify more places where developers have used typealiases in inheriting protocols to effect a same-type constraint on an inherited associated type. Fixes SR-7097 / rdar://problem/38001269.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility |
slavapestov
approved these changes
Mar 6, 2018
| // Infer a same-type requirement between the typealias' underlying | ||
| // type and the inherited associated type. | ||
| addInferredSameTypeReq(inheritedAssocTypeDecl, typealias); | ||
| // Or is constrained. |
There was a problem hiding this comment.
This comment seems unclear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During "expansion" of the requirements of a protocol, we check all of
the inherited associated types against definitions within the
protocol. Also look for concrete types within extensions of that
protocol, so we can identify more places where developers have used
typealiases in inheriting protocols to effect a same-type constraint
on an inherited associated type.
Fixes SR-7097 / rdar://problem/38001269.