Skip to content

[CSBindings] Try to infer bindings from related type variables #15009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Mar 6, 2018

Attempt to use potential bindings inferred for related types variables
discoverable through 'subtype' constraints, this helps to build a
more precise bindings domain for each type variable.

Resolves: rdar://problem/38159133

Attempt to use potential bindings inferred for related types variables
discoverable through 'subtype' constraints, this helps to build a
more precise bindings domain for each type variable.

Resolves: rdar://problem/38159133
@xedin xedin requested a review from rudkx March 6, 2018 03:29
@xedin
Copy link
Contributor Author

xedin commented Mar 6, 2018

/cc @rudkx this is the only way I see to fix this at this point... Maybe with a better join implementation we would not need this...

@xedin
Copy link
Contributor Author

xedin commented Mar 6, 2018

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Mar 6, 2018

@swift-ci please test source compatibility

@rudkx
Copy link
Contributor

rudkx commented Mar 6, 2018

@xedin I’ll pull this down and take a look.

@xedin
Copy link
Contributor Author

xedin commented Mar 6, 2018

@rudkx Thanks!

Copy link
Contributor

@rudkx rudkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this seems okay.

@xedin xedin merged commit 39dc184 into swiftlang:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants