test: configure the windows test environment #15018

compnerd · 2018-03-06T18:22:39Z

This enables lit to at least start running on Windows. There is more
work necessary to get the tests actually passing on Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

compnerd · 2018-03-06T18:23:26Z

CC: @Rostepher @bob-wilson @jrose-apple @troughton @hughbe @AndrewSB @gottesmm

compnerd · 2018-03-06T18:23:42Z

@swift-ci please test

jrose-apple

Looks good to me!

jrose-apple · 2018-03-06T18:50:13Z

test/lit.cfg

@@ -158,8 +158,16 @@ if platform.system() == 'Darwin':
    config.environment['TOOLCHAINS'] = \
        os.environ.get('TOOLCHAINS', config.darwin_xcrun_toolchain)

+
+kIsWindows = platform.system() == 'Windows'


Nitpick: please match the naming conventions for all the other variables in the file (snake_case, no leading "k").

This is a bit more complicated: this is also the name of a variable in the rest of lit (where I stole it from). It is in the core lit infrastructure ... so I'm kinda torn (my personal preference is the snake case).

Ah. Uh…we're setting a variable in the rest of lit? Is it expecting us to do that?

Basically, if it's what Clang does then okay (although it may be worth leaving a comment).

jrose-apple · 2018-03-06T18:54:08Z

Ah, is it worth bothering to make sure this doesn't conflict with Cygwin? I don't know if anyone's actively using that, though.

compnerd · 2018-03-06T18:59:52Z

IIRC, @huonw was the one working on cygwin? I don't know if the tests ever passed in that environment in the first place.

swift-ci · 2018-03-06T19:03:43Z

Build failed
Swift Test Linux Platform
Git Sha - 0a63ed62204a7c8355782556bb89ee7a936cf612

swift-ci · 2018-03-06T19:31:25Z

Build failed
Swift Test OS X Platform
Git Sha - 0a63ed62204a7c8355782556bb89ee7a936cf612

huonw · 2018-03-06T21:55:17Z

Not me, sorry!

troughton · 2018-03-06T22:08:05Z

I think @tinysun212 was working on the Cygwin port.

tinysun212 · 2018-03-07T01:15:44Z

It is difficult to test on the Cygwin in my current situation.
I think this PR is not likely to affect to Cygwin because the added codes are enclosed by elif run_os in ['windows-msvc']:.

compnerd · 2018-03-07T02:41:05Z

@swift-ci please test

swift-ci · 2018-03-07T02:41:29Z

Build failed
Swift Test Linux Platform
Git Sha - 0a63ed62204a7c8355782556bb89ee7a936cf612

swift-ci · 2018-03-07T02:44:03Z

Build failed
Swift Test OS X Platform
Git Sha - 0a63ed62204a7c8355782556bb89ee7a936cf612

AndrewSB · 2018-03-07T17:29:25Z

This is awesome 👍

compnerd · 2018-03-13T20:52:27Z

Okay, I've not had to tweak this in quite some time. I think that this is good from the support side, the tests need adjustment still.

compnerd · 2018-03-13T20:52:32Z

@swift-ci please test

swift-ci · 2018-03-13T21:49:05Z

Build failed
Swift Test Linux Platform
Git Sha - f766208b44fdc1fd7ed46618611f6ae912b88cf7

swift-ci · 2018-03-13T22:16:44Z

Build failed
Swift Test OS X Platform
Git Sha - f766208b44fdc1fd7ed46618611f6ae912b88cf7

compnerd · 2018-03-19T00:05:39Z

@swift-ci please test

swift-ci · 2018-03-19T00:41:34Z

Build failed
Swift Test Linux Platform
Git Sha - f766208b44fdc1fd7ed46618611f6ae912b88cf7

swift-ci · 2018-03-19T00:52:47Z

Build failed
Swift Test OS X Platform
Git Sha - f766208b44fdc1fd7ed46618611f6ae912b88cf7

compnerd · 2018-03-20T18:16:42Z

@swift-ci please test and merge

compnerd · 2018-03-20T21:10:10Z

Please test with following PR:
apple/swift-llvm#81

@swift-ci please test

swift-ci · 2018-03-20T21:10:40Z

Build failed
Swift Test OS X Platform
Git Sha - f766208b44fdc1fd7ed46618611f6ae912b88cf7

swift-ci · 2018-03-20T21:12:06Z

Build failed
Swift Test Linux Platform
Git Sha - f766208b44fdc1fd7ed46618611f6ae912b88cf7

compnerd · 2018-04-25T22:35:39Z

@swift-ci please test

swift-ci · 2018-04-25T23:30:17Z

Build failed
Swift Test Linux Platform
Git Sha - 242578f

compnerd · 2018-05-11T18:15:14Z

@swift-ci please smoke test

compnerd · 2018-11-16T18:23:28Z

@swift-ci please test

swift-ci · 2018-11-16T19:02:04Z

Build failed
Swift Test OS X Platform
Git Sha - fdfe12601879fc2328f63797b1312d615c4568b6

swift-ci · 2018-11-16T19:05:58Z

Build failed
Swift Test Linux Platform
Git Sha - fdfe12601879fc2328f63797b1312d615c4568b6

compnerd · 2018-11-20T04:32:56Z

@swift-ci please test

swift-ci · 2018-11-20T04:34:51Z

Build failed
Swift Test Linux Platform
Git Sha - fdfe12601879fc2328f63797b1312d615c4568b6

swift-ci · 2018-11-20T04:34:58Z

Build failed
Swift Test OS X Platform
Git Sha - fdfe12601879fc2328f63797b1312d615c4568b6

This enables lit to at least start running on Windows. There is more work necessary to get the tests actually passing on Windows.

compnerd · 2018-11-26T20:01:55Z

@swift-ci please smoke test

swift-ci · 2018-11-26T20:03:27Z

Build failed
Swift Test Linux Platform
Git Sha - 46de4205a5935b55aa283f955dcec84da08e8bb7

swift-ci · 2018-11-26T20:21:59Z

Build failed
Swift Test OS X Platform
Git Sha - 46de4205a5935b55aa283f955dcec84da08e8bb7

compnerd · 2018-11-26T20:55:37Z

@swift-ci please test and merge

jrose-apple reviewed Mar 6, 2018

View reviewed changes

compnerd force-pushed the windows-is-lit branch 2 times, most recently from 87452ca to 55a53e3 Compare March 6, 2018 20:37

compnerd force-pushed the windows-is-lit branch from 55a53e3 to 5daef12 Compare March 6, 2018 22:28

compnerd force-pushed the windows-is-lit branch 2 times, most recently from 68fe8e0 to 9b4e0f9 Compare March 7, 2018 05:23

compnerd force-pushed the windows-is-lit branch 3 times, most recently from 1731eb7 to f766208 Compare March 11, 2018 02:03

compnerd force-pushed the windows-is-lit branch from f766208 to c2011d1 Compare March 20, 2018 18:14

compnerd force-pushed the windows-is-lit branch 2 times, most recently from b0d9547 to 242578f Compare April 25, 2018 22:35

compnerd force-pushed the windows-is-lit branch from 242578f to d5fa59f Compare May 2, 2018 20:41

compnerd force-pushed the windows-is-lit branch from d5fa59f to 6062433 Compare May 11, 2018 18:11

compnerd force-pushed the windows-is-lit branch from 6062433 to 3602d93 Compare June 4, 2018 01:48

compnerd force-pushed the windows-is-lit branch from 3602d93 to fdfe126 Compare November 16, 2018 18:02

compnerd force-pushed the windows-is-lit branch from fdfe126 to 46de420 Compare November 20, 2018 04:32

test: configure the windows test environment

0faf870

This enables lit to at least start running on Windows. There is more work necessary to get the tests actually passing on Windows.

compnerd force-pushed the windows-is-lit branch from 46de420 to 0faf870 Compare November 26, 2018 19:59

compnerd merged commit cd8e12d into swiftlang:master Nov 27, 2018

compnerd deleted the windows-is-lit branch November 27, 2018 00:39

compnerd mentioned this pull request Oct 31, 2018

[SR-9149] setup lit for Windows tests #51645

Closed

test: configure the windows test environment #15018

test: configure the windows test environment #15018

Uh oh!

Conversation

compnerd commented Mar 6, 2018

Uh oh!

compnerd commented Mar 6, 2018

Uh oh!

compnerd commented Mar 6, 2018

Uh oh!

jrose-apple left a comment

Choose a reason for hiding this comment

Uh oh!

jrose-apple Mar 6, 2018

Choose a reason for hiding this comment

Uh oh!

compnerd Mar 6, 2018

Choose a reason for hiding this comment

Uh oh!

jrose-apple Mar 6, 2018

Choose a reason for hiding this comment

Uh oh!

jrose-apple commented Mar 6, 2018

Uh oh!

compnerd commented Mar 6, 2018

Uh oh!

swift-ci commented Mar 6, 2018

Uh oh!

swift-ci commented Mar 6, 2018

Uh oh!

huonw commented Mar 6, 2018

Uh oh!

troughton commented Mar 6, 2018

Uh oh!

tinysun212 commented Mar 7, 2018

Uh oh!

compnerd commented Mar 7, 2018

Uh oh!

swift-ci commented Mar 7, 2018

Uh oh!

swift-ci commented Mar 7, 2018

Uh oh!

AndrewSB commented Mar 7, 2018

Uh oh!

compnerd commented Mar 13, 2018

Uh oh!

compnerd commented Mar 13, 2018

Uh oh!

swift-ci commented Mar 13, 2018

Uh oh!

swift-ci commented Mar 13, 2018

Uh oh!

compnerd commented Mar 19, 2018

Uh oh!

swift-ci commented Mar 19, 2018

Uh oh!

swift-ci commented Mar 19, 2018

Uh oh!

compnerd commented Mar 20, 2018

Uh oh!

compnerd commented Mar 20, 2018

Uh oh!

swift-ci commented Mar 20, 2018

Uh oh!

swift-ci commented Mar 20, 2018

Uh oh!

compnerd commented Apr 25, 2018

Uh oh!

swift-ci commented Apr 25, 2018

Uh oh!

compnerd commented May 11, 2018

Uh oh!

compnerd commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

swift-ci commented Nov 16, 2018

Uh oh!

compnerd commented Nov 20, 2018

Uh oh!