Skip to content

test: convert rm -rf && mkdir -p into %empty-directory #15020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2018

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Mar 6, 2018

This converts the instances of the pattern for which we have a proper
substitution in lit. This will make it easier to replace it
appropriately with Windows equivalents.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Mar 6, 2018

@swift-ci please test and merge

@compnerd
Copy link
Member Author

compnerd commented Mar 6, 2018

@gribozavr, @gottesmm: probably makes you two happy :-)

@compnerd
Copy link
Member Author

compnerd commented Mar 6, 2018

CC: @Rostepher

@compnerd compnerd force-pushed the empty branch 3 times, most recently from 39e75aa to 8b67dcb Compare March 6, 2018 19:54
@compnerd
Copy link
Member Author

compnerd commented Mar 6, 2018

@swift-ci please test and merge

@Rostepher
Copy link
Contributor

I greatly appreciate this PR! Thanks for cleaning this up.

@Rostepher
Copy link
Contributor

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 6, 2018

Build failed
Swift Test OS X Platform
Git Sha - 106392e581278b3209bd10af915b025632aff239

@swift-ci
Copy link
Contributor

swift-ci commented Mar 6, 2018

Build failed
Swift Test Linux Platform
Git Sha - 106392e581278b3209bd10af915b025632aff239

@compnerd
Copy link
Member Author

compnerd commented Mar 6, 2018

Sure thing! Okay, the failures are "valid". The file content changes has changed offsets. I'll adjust that accordingly.

This converts the instances of the pattern for which we have a proper
substitution in lit.  This will make it easier to replace it
appropriately with Windows equivalents.
@compnerd
Copy link
Member Author

compnerd commented Mar 7, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 7, 2018

Build failed
Swift Test Linux Platform
Git Sha - 8b67dcb490af986b1f6bea5a3b181bd1811eb6a5

@swift-ci
Copy link
Contributor

swift-ci commented Mar 7, 2018

Build failed
Swift Test OS X Platform
Git Sha - 8b67dcb490af986b1f6bea5a3b181bd1811eb6a5

@compnerd compnerd merged commit 1b6e691 into swiftlang:master Mar 7, 2018
@compnerd compnerd deleted the empty branch March 7, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants