Skip to content

[build-script] Disable building llbuild Swift bindings #15022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Mar 6, 2018

The CMake support in llbuild is finding the compiler in the system
instead of the build products. This causes build errors if Swift is old
on a system.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

The CMake support in llbuild is finding the compiler in the system
instead of the build products. This causes build errors if Swift is old
on a system.
@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 6, 2018

@swift-ci please smoke test

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 6, 2018

/cc @gottesmm

@gottesmm
Copy link
Contributor

gottesmm commented Mar 6, 2018

Thanks!

@gottesmm
Copy link
Contributor

gottesmm commented Mar 6, 2018

@aciidb0mb3r Can we get a force merge on this from the buildczar? It should just work, no?

@aciidgh
Copy link
Contributor Author

aciidgh commented Mar 6, 2018

Yep this is safe. @eeckstein can you force merge this?

@eeckstein eeckstein merged commit 14ec3d7 into swiftlang:master Mar 6, 2018
@aciidgh aciidgh deleted the disable-llbuild-bindings branch March 6, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants