[AST] Disable comment printing while emitting diagnostics #15032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a problem in PCH builds where source manager might end up having unorderable source locations for comments, to work around this (which is going to be fixed separately) let's disable comment printing while emitting diagnostics since such comments are not required. Resolves: rdar://problem/38203776
jrose-apple
approved these changes
Mar 7, 2018
There was a problem hiding this comment.
This is probably a good idea anyway. Today any decls we print for diagnostics are either inserted text (see TypeCheckProtocol's use of PrintOptions::printForDiagnostics, which disables this flag already) or something to show on the command line, which only prints one line of context anyway. (That's also what makes it okay that there's no test for this—we don't expect any output to change in practice.)
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem in PCH builds where source manager might
end up having unorderable source locations for comments, to work
around this (which is going to be fixed separately) let's
disable comment printing while emitting diagnostics since
such comments are not required.
Resolves: rdar://problem/38203776