[Devirtualize] Support devirtualization of witness methods when we have a polymorphic type and no substitutions required #15064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
slavapestov
reviewed
Mar 8, 2018
| @@ -2438,7 +2438,6 @@ CanSILFunctionType | |||
| SILFunctionType::substGenericArgs(SILModule &silModule, | |||
| SubstitutionList subs) { | |||
| if (subs.empty()) { | |||
| assert(!isPolymorphic() && "no args for polymorphic substitution"); | |||
There was a problem hiding this comment.
I think the right assertion is (!isPolymorphic() || getGenericSignature()->areAllParamsConcrete())
…ve a polymorphic type and no substitutions required SILGen is generating code with “shadow” requirements: convention(witness_method: ApplyRegStruct) <τ_0_0 where τ_0_0 == Type> (@inout Array<Type>) -> () { // no use of τ_0_0 inside In this case we have an empty substitution map but a polymorphic function type We should relax the assert when creating apply instructions to support this case.
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/38085760
SILGen is generating code with “shadow” requirements:
convention(witness_method: ApplyRegStruct) <τ_0_0 where τ_0_0 == Type> (@inout Array) -> () {
// no use of τ_0_0 inside
In this case we have an empty substitution map but a polymorphic function type
We should relax the assert when creating apply instructions to support this case.