[+0-all-args] Fix SILGenBuilder::createFunctionInputArgument(...) for… #15089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
… in_guaranteed parameters This method was not distinguishing in between in_guaranteed and in parameters. This would cause the curry thunk where this is used to not copy in_guaranteed parameters before passing in the parameter to the partial_apply. This can not affect +1 code since the curry thunk will always have self at +1. I also refactored code in: 1. SILGenPoly. 2. SILGenProlog. 3. SILGenConstructor. to use this function instead of their own reimplementations of the same thing. This should be NFC for +1 code and is tested by test updates when +0 is enabled. rdar://34222540
gottesmm
force-pushed
the
pr-215a0ace32f79bcd4c1910c06c19468d27720cfe
branch
from
45f522c to
8af8e4f
Compare
|
@swift-ci smoke test and merge |
3 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in_guaranteed parameters
This method was not distinguishing in between in_guaranteed and in
parameters. This would cause the curry thunk where this is used to not copy
in_guaranteed parameters before passing in the parameter to the
partial_apply. This can not affect +1 code since the curry thunk will always
have self at +1.
I also refactored code in:
to use this function instead of their own reimplementations of the same thing.
This should be NFC for +1 code and is tested by test updates when +0 is enabled.
rdar://34222540