Skip to content

Fix bug on OutputFileMap parser when parsing beyond JSON. #15111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2018
Merged

Fix bug on OutputFileMap parser when parsing beyond JSON. #15111

merged 1 commit into from
Mar 9, 2018

Conversation

davidungar
Copy link
Contributor

Fixes a bug that caused the parser to skip every other line.

@davidungar davidungar requested a review from jrose-apple March 9, 2018 17:58
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

jrose-apple
jrose-apple approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone watching, I'm seeing what happens if we mark the copy constructor on llvm::yaml::Node as deleted, and if that works out I'll send a patch over to LLVM.

@davidungar davidungar merged commit 2608726 into swiftlang:master Mar 9, 2018
@jrose-apple jrose-apple mentioned this pull request Mar 9, 2018
Merged
@davidungar davidungar deleted the fix-OFM-parser branch June 14, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidungar @jrose-apple